[PATCH 7 of 7] tests: conditionalize color output on abort

Matt Harbison mharbison72 at gmail.com
Mon Aug 20 21:55:51 EDT 2018


On Mon, 20 Aug 2018 08:56:42 -0400, Yuya Nishihara <yuya at tcha.org> wrote:

> On Sat, 18 Aug 2018 15:17:06 -0400, Matt Harbison wrote:
>> # HG changeset patch
>> # User Matt Harbison <matt_harbison at yahoo.com>
>> # Date 1534619704 14400
>> #      Sat Aug 18 15:15:04 2018 -0400
>> # Node ID 37ffffeb716e10bbc1d5052923b7d0ff14090485
>> # Parent  5acb07cbe379202759848a2cb9d5da24df01f1a1
>> tests: conditionalize color output on abort
>>
>> This broke in afc4ad706f9c.  I'm not sure why other aborts don't need  
>> to be
>> conditionalized, but `hg help foo` does abort in red for both msys and  
>> cmd.exe.
>>
>> diff --git a/tests/test-extension.t b/tests/test-extension.t
>> --- a/tests/test-extension.t
>> +++ b/tests/test-extension.t
>> @@ -1255,8 +1255,10 @@ Broken disabled extension and command:
>>    >     pass
>>    > EOF
>>    $ hg --config extensions.path=./path.py help foo > /dev/null
>> -  abort: no such help topic: foo
>> -  (try 'hg help --keyword foo')
>> +  abort: no such help topic: foo (no-windows !)
>> +  (try 'hg help --keyword foo') (no-windows !)
>> +  \x1b[0;31mabort: no such help topic: foo\x1b[0m (esc) (windows !)
>> +  \x1b[0;31m(try 'hg help --keyword foo')\x1b[0m (esc) (windows !)
>
> That might be because stdout is redirected to "nul" and "nul" is a tty on
> Windows!

That's... interesting.  Dropping the redirect works.  I'll send a followup.


More information about the Mercurial-devel mailing list