[PATCH] color: issue warning in yellow

[Yuya Nishihara]

On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via Mercurial-devel wrote:
> On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott <spectral at google.com> wrote:
> 
> > Bright/bold yellow should be considered unavailable.  "Normal" yellow,
> > which is closer to brown or maybe gold on many screens, is fine.
> >
> 
> Ah, and we already use yellow for a few things (as you also pointed out).
> Sorry I didn't even check that.
> 
> 
> >   At Google, and I think other tools like clang, generally use magenta I
> > believe, but I have no strong preference.  Keep in mind that ui.prompt is
> > also yellow a couple lines below.
> >
> 
> Good point about ui.prompt. Yellow seems like the obvious choice for
> warnings, so do we want to change the color for the prompt?

FWIW, I don't like the red-colored "error" since it's hard to spot in
white-on-black screen. Well, it's readable, but not significant. A plain
"yellow" (i.e. dark yellow) would have the same effect.