D4279: manifest: use rev() instead of nodemap.__contains__
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed Aug 22 12:38:12 EDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG61700d525a3b: manifest: use rev() instead of nodemap.__contains__ (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4279?vs=10351&id=10526
REVISION DETAIL
https://phab.mercurial-scm.org/D4279
AFFECTED FILES
mercurial/manifest.py
CHANGE DETAILS
diff --git a/mercurial/manifest.py b/mercurial/manifest.py
--- a/mercurial/manifest.py
+++ b/mercurial/manifest.py
@@ -1453,20 +1453,20 @@
if tree:
if self._revlog._treeondisk:
if verify:
- dirlog = self.getstorage(tree)
- if node not in dirlog.nodemap:
- raise LookupError(node, dirlog.indexfile,
- _('no node'))
+ # Side-effect is LookupError is raised if node doesn't
+ # exist.
+ self.getstorage(tree).rev(node)
+
m = treemanifestctx(self, tree, node)
else:
raise error.Abort(
_("cannot ask for manifest directory '%s' in a flat "
"manifest") % tree)
else:
if verify:
- if node not in self._revlog.nodemap:
- raise LookupError(node, self._revlog.indexfile,
- _('no node'))
+ # Side-effect is LookupError is raised if node doesn't exist.
+ self._revlog.rev(node)
+
if self._treemanifests:
m = treemanifestctx(self, '', node)
else:
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list