D4363: log: respect graphshorten on terminal nodes (collapsing o-~ to just o)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Aug 23 17:32:55 EDT 2018


martinvonz added a comment.


  Can we have a test for this?

INLINE COMMENTS

> graphmod.py:301
>      shift_size = max((edgechars.count(None) * 2) - 1, 0)
> -    while len(lines) < 3 + shift_size:
> +    minlines = 3 if not state['graphshorten'] else 1
> +    while len(lines) < minlines + shift_size:

Since it's just the single `|` line that goes away with this patch, why does `minlines` change by 2 and not by 1?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4363

To: spectral, #hg-reviewers, indygreg
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list