D4344: tracing: new module to make tracing events in hg easier

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Aug 24 13:02:15 EDT 2018


indygreg added inline comments.

INLINE COMMENTS

> tracing.py:31-34
> +        _pipe.write('START %s %s\n' % (_session, whence))
> +        yield
> +    finally:
> +        _pipe.write('END %s %s\n' % (_session, whence))

Per my comment in https://phab.mercurial-scm.org/D4342, I think we should consider recording the timing from here so times aren't skewed due to the presence of pipe I/O. That will introduce some overhead in the traced process. But such is the price to be paid for accurate time reporting, I suppose.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4344

To: durin42, #hg-reviewers
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list