D4284: copies: correctly skip directories that have already been considered
spectral (Kyle Lippincott)
phabricator at mercurial-scm.org
Fri Aug 24 16:35:02 EDT 2018
spectral added inline comments.
INLINE COMMENTS
> jpsugar wrote in copies.py:615
> Maybe do this after the debug loop to avoid an un-pretty output?
I personally have no preference, but had been trying to make this an unobservable difference, whereas that is technically observable (though I doubt anything is relying on this particular one, we have had reports of tooling like one of the IDEs depending on the format of some of our debug messages in the past)
Asking martinvonz in person, they prefer the slashes on the end to more strongly indicate that this is a directory, especially in the debug messages (which most people will never see).
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4284
To: spectral, #hg-reviewers
Cc: jpsugar, mercurial-devel
More information about the Mercurial-devel
mailing list