D4365: match: make exactmatcher.visitchildrenset return file children as well

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Aug 25 00:35:30 EDT 2018


yuja added a comment.


  > +        if not self._fileset or dir not in self._dirs:
  
  Just curious why you've added `not self._fileset`.
  
  Except a vast style change, the important part is just this:
  
    @@ -590,7 +590,7 @@
             if dir not in self._dirs:
                 return set()
     
    -        candidates = self._dirs - {'.'}
    +        candidates = self._fileset | self._dirs - {'.'}
             if dir != '.':
                 d = dir + '/'
                 candidates = set(c[len(d):] for c in candidates if

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4365

To: spectral, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list