D4392: manifest: use public API for obtaining storage object

[indygreg (Gregory Szorc)]

indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We should not be accessing private attributes on the manifestlog,
  since its behavior is governed by an interface.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4392

AFFECTED FILES
  mercurial/manifest.py

CHANGE DETAILS

diff --git a/mercurial/manifest.py b/mercurial/manifest.py
--- a/mercurial/manifest.py
+++ b/mercurial/manifest.py
@@ -1317,7 +1317,7 @@
             self = manifestrevlogref()
             if repo is None or self is None:
                 return
-            if repo.manifestlog._revlog is not self:
+            if repo.manifestlog.getstorage(b'') is not self:
                 # there's a different manifest in play now, abort
                 return
             self._fulltextcache.write()
@@ -1583,7 +1583,7 @@
         self._manifestdict = manifestdict()
 
     def _storage(self):
-        return self._manifestlog._revlog
+        return self._manifestlog.getstorage(b'')
 
     def new(self):
         return memmanifestctx(self._manifestlog)
@@ -1619,7 +1619,7 @@
         #self.linkrev = store.linkrev(rev)
 
     def _storage(self):
-        return self._manifestlog._revlog
+        return self._manifestlog.getstorage(b'')
 
     def node(self):
         return self._node
@@ -1689,7 +1689,7 @@
         self._treemanifest = treemanifest()
 
     def _storage(self):
-        return self._manifestlog._revlog
+        return self._manifestlog.getstorage(b'')
 
     def new(self, dir=''):
         return memtreemanifestctx(self._manifestlog, dir=dir)



To: indygreg, #hg-reviewers
Cc: mercurial-devel