D4401: run-tests: don't append rtendtracing logs if pipe is /dev/null

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Aug 27 17:42:11 UTC 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  If HGCATAPULTSERVERPIPE is not set, we set it to /dev/null, so we need to make
  sure the value is not /dev/null before appending logs.
  
  This fixes some of test-run-tests.t failures.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4401

AFFECTED FILES
  tests/run-tests.py

CHANGE DETAILS

diff --git a/tests/run-tests.py b/tests/run-tests.py
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -1389,7 +1389,8 @@
         if os.getenv('MSYSTEM'):
             script.append(b'alias pwd="pwd -W"\n')
 
-        if os.getenv('HGCATAPULTSERVERPIPE'):
+        hgcatapult = os.getenv('HGCATAPULTSERVERPIPE')
+        if hgcatapult and hgcatapult != '/dev/null':
             # Kludge: use a while loop to keep the pipe from getting
             # closed by our echo commands. The still-running file gets
             # reaped at the end of the script, which causes the while



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list