D4380: revert: fix the inconsistency of status msgs in --interactive mode

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Fri Aug 31 07:53:48 EDT 2018


yuja added a comment.


  >> +                        if ui.verbose or not exact:
  >  > +                            if not isinstance(msg, bytes):
  >  > +                                msg = msg(abs)
  > 
  > Does this conditional doing something useful because I don't see any change in the tests if I remove line 3023,3024?
  
  Probably no. `msg` should never be a callable since https://phab.mercurial-scm.org/rHG0d57bf80c7cbf8ac497ef2727953be13c230e5be.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4380

To: khanchi97, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list