D4431: py3: don't use dict.iterkeys() in hgext/fastannotate/context.py

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Aug 31 20:46:46 UTC 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  dict.iterkeys() is not present on Python 3.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4431

AFFECTED FILES
  hgext/fastannotate/context.py

CHANGE DETAILS

diff --git a/hgext/fastannotate/context.py b/hgext/fastannotate/context.py
--- a/hgext/fastannotate/context.py
+++ b/hgext/fastannotate/context.py
@@ -133,7 +133,7 @@
 def hashdiffopts(diffopts):
     diffoptstr = str(sorted(
         (k, getattr(diffopts, k))
-        for k in mdiff.diffopts.defaults.iterkeys()
+        for k in mdiff.diffopts.defaults
     ))
     return hashlib.sha1(diffoptstr).hexdigest()[:6]
 



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list