D4428: zsh_completion: complete shelve and unshelve

spectral (Kyle Lippincott) phabricator at mercurial-scm.org
Fri Aug 31 18:43:53 EDT 2018


spectral added a comment.


  (Not marking accepted, though I'm fine with it going in as is, so that we get a chance to answer the questions before it lands)

INLINE COMMENTS

> zsh_completion:1272
> +
> +  _arguments -s -S : $_hg_global_opts $_hg_pat_opts \
> +  '(--addremove -A)'{-A,--addremove}'[mark new/missing files as added/removed before shelving]' \

Mine has a --cleanup flag.  Not sure where that came from, and I think it's dangerous as heck and I don't like it, but ... should we list it?  (I'm 100% fine with the answer being "no, it's too scary" :))

> zsh_completion:1277
> +  '--date=[shelve with the specified commit date]:date' \
> +  '(--delete -d)'{-d,--delete}'[delete the named shelved change(s)]' \
> +  '(--edit -e)'{-e,--edit}'[invoke editor on commit messages]' \

Optional: should we make --delete exclusive with anything else? what about --list, patch, stat..?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4428

To: av6, #hg-reviewers
Cc: spectral, mercurial-devel


More information about the Mercurial-devel mailing list