D4438: httppeer: add TODO about delayed handling of ^C

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Aug 31 22:57:22 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  When testing wire protocol v2 with large responses, I noticed that
  ^C doesn't result in immediate termination. I'm not sure what the
  root cause is. Let's add a TODO so we don't forget about it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4438

AFFECTED FILES
  mercurial/httppeer.py

CHANGE DETAILS

diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py
--- a/mercurial/httppeer.py
+++ b/mercurial/httppeer.py
@@ -728,6 +728,8 @@
         if not self._responsef:
             return
 
+        # TODO ^C here may not result in immediate program termination.
+
         try:
             self._responsef.result()
         finally:



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list