D5374: fastannotate: use progress helper
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Dec 5 17:39:52 UTC 2018
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5374
AFFECTED FILES
hgext/fastannotate/context.py
CHANGE DETAILS
diff --git a/hgext/fastannotate/context.py b/hgext/fastannotate/context.py
--- a/hgext/fastannotate/context.py
+++ b/hgext/fastannotate/context.py
@@ -398,7 +398,8 @@
# 3rd DFS does the actual annotate
visit = initvisit[:]
- progress = 0
+ progress = self.ui.makeprogress(('building cache'),
+ total=len(newmainbranch))
while visit:
f = visit[-1]
if f in hist:
@@ -437,10 +438,7 @@
del pcache[f]
if ismainbranch: # need to write to linelog
- if not self.ui.quiet:
- progress += 1
- self.ui.progress(_('building cache'), progress,
- total=len(newmainbranch))
+ progress.increment()
bannotated = None
if len(pl) == 2 and self.opts.followmerge: # merge
bannotated = curr[0]
@@ -450,8 +448,7 @@
elif showpath: # not append linelog, but we need to record path
self._node2path[f.node()] = f.path()
- if progress: # clean progress bar
- self.ui.write()
+ progress.complete()
result = [
((self.revmap.rev2hsh(fr) if isinstance(fr, int) else fr.node()), l)
To: martinvonz, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list