D5408: progress: [RFC] avoid ui.configbool() lookup when progress bar is active

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Dec 11 08:45:05 EST 2018


yuja added a comment.


  The idea sounds good to me. Going further, maybe we can get rid of the `ui`
  reference from the progbar. There's a reference cycle.
  
  >   DO NOT LAND. test-check-config.t COMPLAINS FOR SOME REASON.
  
  Probably missing `# developer config: progress.debug`. The checker isn't
  aware of `self` being `ui`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5408

To: indygreg, #hg-reviewers
Cc: yuja, pulkit, mercurial-devel


More information about the Mercurial-devel mailing list