[PATCH 2 of 2 evolve-ext] resolves 6028: return return (False, None) instead of return (False, '')

Pulkit Goyal 7895pulkit at gmail.com
Tue Dec 11 11:31:52 EST 2018


On Tue, Dec 11, 2018 at 7:18 PM James Reynolds <
james.glenn.reynolds at gmail.com> wrote:

>
> On Wed, Dec 5, 2018 at 5:15 PM Martin von Zweigbergk <
> martinvonz at google.com> wrote:
>
>>
>>
>> On Tue, Dec 4, 2018 at 1:19 PM James Reynolds <
>> james.glenn.reynolds at gmail.com> wrote:
>>
>>> # HG changeset patch
>>> # User James Reynolds <james.glenn.reynolds at gmail.com>
>>> # Date 1543952045 18000
>>> #      Tue Dec 04 14:34:05 2018 -0500
>>> # Branch stable
>>> # Node ID 6ea3ff2517b9ebf12f0678f28c9942c45c5924ce
>>> # Parent  91aec886fc8701398182ab83adcdc04c86735c1d
>>> # EXP-Topic issue6028
>>> resolves 6028: return return (False, None) instead of return (False, '')
>>>
>>
>> repo[''] used to mean repo['.']. Is the right return value still (False,
>> None)?
>>
>
> Makes sense to me. I think Pulkit Goyal said he was going to take a look
> at this.
>

Sorry for missing to have a look before. I agree with @martinvonz
suggestion and the default return value should be '.'.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20181211/ea435045/attachment.html>


More information about the Mercurial-devel mailing list