D5409: remotefilelog: accepting a None node to cmp

Yuya Nishihara yuya at tcha.org
Thu Dec 13 06:39:01 EST 2018


>   Oops, my oversight - what's passed to cmp is not the same that's compared to None in that if :) I have even less confidence on this now.

And `workingfilectx.cmp(self, fctx)` flips `self` and `fctx` as it knows
`self._filenode` is None, and the other's wouldn't be None. I don't like it,
but that's how fctx.cmp() is working.


More information about the Mercurial-devel mailing list