D5439: rust-cpython: binding for AncestorsIterator

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Mon Dec 17 09:20:55 EST 2018


gracinet added a comment.


  @yuja thanks for spotting the Python3 incompatibility. As you can guess, I didn't compile with Python 3, and actually I hadn't even defined the features to that extent.
  I will submit separately a change that takes care of the build with Python 3 before updating that one (but yes, got `test-rust-ancestor.py` to pass).
  OTOH I'll have to keep the loop so that I can get the early return upon error (otherwise we'd get a Vec<PyResult<...>>
  
  @kevincox thanks for the shorter version, wasn't used to these sugars when I wrote this long ago :-)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5439

To: gracinet, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list