D5443: ancestor: uniformity of calling lazyancestors classes

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Sat Dec 22 11:22:26 EST 2018


gracinet added a comment.


  @yuja I'm not sure by what you consider exactly to be internals here. If that's the `[5]` and [6]`, maybe a `parents(revision)` method on the index would be better ? The obvious drawback would be to write more C code.
  
  Given that my ultimate goal here is to delegate the whole `ancestors` module to `policy.importmod`, where would we have the factory function you're thinking of ? In some sense, that's the role `revlog.py` fulfills isn't it ? Maybe all access to ancestors logic should keep on going through it ?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5443

To: gracinet, indygreg, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list