D5440: rust: core implementation for lazyancestors
gracinet (Georges Racinet)
phabricator at mercurial-scm.org
Sat Dec 22 11:24:22 EST 2018
gracinet added a comment.
@yuja, yes a `Graph` not implementing `Clone` is already a good thing, as it avoids to implement `Clone` in `hg-direct-ffi` prematurely. I think the whole `hg::LazyAncestors` can end up being useful from core Rust code, too, that's why I prefer that to a `hg-cpython` only implementation.
INLINE COMMENTS
> kevincox wrote in ancestors.rs:124
> I think this variable makes the code harder to read. I would just repeat the calls to `.len()`.
agreed, and made a clearer version of the last lines as an OR statement using `self.seen.is_empty()`
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5440
To: gracinet, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel
More information about the Mercurial-devel
mailing list