D5439: rust-cpython: binding for AncestorsIterator

gracinet (Georges Racinet) phabricator at mercurial-scm.org
Sat Dec 22 11:25:58 EST 2018


gracinet added a comment.


  @yuja actually my first version of `CoreIterator` (and later `CoreLazy`) used the `hg::AncestorsIterator` spelling, but actually I believe we might end up after a while not exporting everything at the top of the `hg` crate, leaving us either to `use hg::ancestors`, giving us a long and puzzling `ancestors::AncestorsIterator` or directly as `hg:ancestors::AncestorsIterator`. I don't think it would be tasteful to `use hg::ancestors as core`.
  
  That's why I found it clearer to call them `CoreIterator` etc. But I can change it if you really dislike them.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5439

To: gracinet, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list