D5441: rust-cpython: binding for LazyAncestors

kevincox (Kevin Cox) phabricator at mercurial-scm.org
Sat Dec 22 11:57:06 EST 2018


kevincox accepted this revision.
kevincox added inline comments.

INLINE COMMENTS

> ancestors.rs:108
> +                Err(e) => {
> +                    return Err(GraphError::new(py, format!("{:?}", e)));
> +                }

.map_err(|e| GraphError::new(py, format!("{:?}", e)))

Or even better is to implement `Into` so that you can use `?`

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5441

To: gracinet, #hg-reviewers, kevincox
Cc: yuja, durin42, kevincox, mercurial-devel


More information about the Mercurial-devel mailing list