D5474: obsutil: fix the issue5686

khanchi97 (Sushil khanchi) phabricator at mercurial-scm.org
Sun Dec 23 07:13:21 EST 2018


khanchi97 added a comment.


  @av6  Thanks for the review. I will update it.

INLINE COMMENTS

> av6 wrote in test-obsmarker-template.t:2511
> The new output looks somewhat more correct, but not quite. This changeset definitely wasn't just pruned, but it also wasn't rewritten either: it was split, and you can see correct `hg fatelog` output in the block below this one. The difference between them is wdir parent is different and the fatelog below has --hidden flag.
> 
> So is it expected that this patch doesn't fully fix this particular issue?

wdir parent is not making a difference here. If we pass `--hidden` here without updating the wdir parent, it will show the same result as block below. Maybe, this changed output is correct as it including those revision only which are visible to user.
So when we pass `--hidden` that hidden cset is visible and it outputs that it was a split operation.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5474

To: khanchi97, #hg-reviewers
Cc: av6, mercurial-devel


More information about the Mercurial-devel mailing list