D5483: amend:added rewrite.updatetimestamp config option(issue5828)

[yuja (Yuya Nishihara)]

yuja added a comment.


  > +$ hg amend --config rewrite.updatetimestamp=True
  >  +$ hg log --limit 2
  >  +changeset:   40473:e64479cbaf37
  
  Okay, so these tests don't run because these lines don't start with `  $`.
  
  > +coreconfigitem('rewrite', 'updatetimestamp',
  
  Need dash per https://www.mercurial-scm.org/wiki/UIGuideline#config
  
  And please update mercurial/help/config.txt as well.
  
  > diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
  > 
  > - a/mercurial/cmdutil.py +++ b/mercurial/cmdutil.py @@ -2545,6 +2545,10 @@ pureextra = extra.copy() extra['amend_source'] = old.hex()
  > 
  >   +        updatetime = ui.configbool('rewrite','updatetimestamp') +        if updatetime==True:
  
  `if updatetime:` (or simply `if ui.configbool(...):`)

REVISION DETAIL
  https://phab.mercurial-scm.org/D5483

To: taapas1128, #hg-reviewers
Cc: yuja, mercurial-devel