D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Thu Dec 27 07:16:28 EST 2018


pulkit added inline comments.

INLINE COMMENTS

> commands.py:4441
>              pullopargs['remotebookmarks'] = remotebookmarks
>              for b in opts['bookmark']:
>                  b = repo._bookmarks.expandname(b)

@yuja this one? I thought if the above condition is true, this will be fine, but now I see `or rev`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5484

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list