D5484: pull: use opts.get('bookmark') instead of opts['bookmark']

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Dec 27 08:17:49 EST 2018


yuja added a comment.


  > @@ -4438,7 +4438,7 @@
  > 
  >   remotebookmarks = fremotebookmarks.result()
  >   remotebookmarks = bookmarks.unhexlifybookmarks(remotebookmarks)
  >   pullopargs['remotebookmarks'] = remotebookmarks
  > 
  > - for b in opts['bookmark']: +            for b in opts.get('bookmark'):
  
  Still wrong. It's `for b in None`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5484

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list