D5485: log: fixes line wrap on diffstat (issue5800)

Yuya Nishihara yuya at tcha.org
Sun Dec 30 03:56:42 EST 2018


> -        return max(i * graphwidth // maxtotal, int(bool(i)))
> +        return max(i * graphwidth // max(diffstatsum(stats)), int(bool(i)))

Doesn't look correct. Why taking max of
`(maxname, maxtotal, totaladds, totalremoves, hasbinary)`?

IIUC, the problem is that the `width` parameter is incorrect because of
graph lines.


More information about the Mercurial-devel mailing list