D1905: strip: use in-place revset formatspec instead of %-formatting ourselves

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Feb 1 16:22:52 EST 2018


martinvonz added inline comments.

INLINE COMMENTS

> strip.py:218
>              # between the working context and uctx
> -            descendantrevs = repo.revs("%s::." % uctx.rev())
> +            descendantrevs = repo.revs("%s::.", uctx.rev())
>              changedfiles = []

I would expect "%d" with a revision number (such as  uctx.rev()). I saw that that's also what Yuya suggested on https://phab.mercurial-scm.org/D1884. Fixing in flight.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1905

To: durin42, #hg-reviewers, pulkit, indygreg
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list