D1992: mdiff: use slice instead of index on bytestr when checking single bytes

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Feb 1 18:31:15 EST 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  I'd be curious if there is a perf hit to this. The slicing API is a bit more involved than `__getitem__` at the C layer. But since this is Python code, my guess is run time is dominated by Python function call overhead and we don't notice a perf difference.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1992

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list