D1919: phabricator: specify API tokens per host, rather than per repo
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Thu Feb 1 18:41:50 EST 2018
indygreg added a comment.
In https://phab.mercurial-scm.org/D1919#33462, @durin42 wrote:
> I like this, and I'm fine with the backwards incompatible change in contrib. How do others feel?
I'm fine with BC in contrib.
One thing to bikeshed is if the `[phabricator]` section is the best place for credentials. We already have `[auth]` for storing credentials. But as long as we don't care about breaking BC, this patch is fine for now.
Another thing to consider is reading things from `.arcconfig` files and reading the API token however Arcanist does it (as the comment in this file suggests).
FWIW Mozilla will likely start leaning on this extension pretty soon. Look for a push from us to move it to core before the next release.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince, #hg-reviewers, durin42
Cc: indygreg, durin42, pulkit, mercurial-devel
More information about the Mercurial-devel
mailing list