[PATCH 1 of 8] bookmarks: drop deprecated methods (API)

Yuya Nishihara yuya at tcha.org
Sat Feb 3 03:23:47 EST 2018


On Sat, 03 Feb 2018 01:34:57 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1517631655 18000
> #      Fri Feb 02 23:20:55 2018 -0500
> # Node ID d293af8e5a4a48a38ff9103e129c1af5719081c1
> # Parent  c8e2d6ed1f9ea4eee7b28250b5aff22433d538b6
> bookmarks: drop deprecated methods (API)

Queued patches other than this, thanks.

> diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py
> --- a/mercurial/bookmarks.py
> +++ b/mercurial/bookmarks.py
> @@ -102,32 +102,14 @@
>          self._active = mark
>          self._aclean = False
>  
> -    def __setitem__(self, *args, **kwargs):
> -        msg = ("'bookmarks[name] = node' is deprecated, "
> -               "use 'bookmarks.applychanges'")
> -        self._repo.ui.deprecwarn(msg, '4.3')
> -        self._set(*args, **kwargs)

We'd probably better to kill these dict functions by raising NotImplementedError
or ProgrammingError. It's pretty easy to use them by mistake.


More information about the Mercurial-devel mailing list