D2026: tests: add low-level SSH protocol tests

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Mon Feb 5 11:46:49 EST 2018


indygreg marked 2 inline comments as done.
indygreg added inline comments.

INLINE COMMENTS

> lothiraldan wrote in test-ssh-proto.t:114
> Is the SSHSERVERMODE needed here?

Yes. `dummyssh` will run `hg serve --stdio` and that process needs to inherit the environment variable so it ignores the `hello` command.

> lothiraldan wrote in test-ssh-proto.t:129
> Is the SSHSERVERMODE needed here?

Ditto.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2026

To: indygreg, #hg-reviewers
Cc: lothiraldan, mercurial-devel


More information about the Mercurial-devel mailing list