D2030: sshpeer: remove frivolous call to _cleanup()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Feb 6 08:24:23 EST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rHG94ba29934f00: sshpeer: remove frivolous call to _cleanup() (authored by indygreg, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2030?vs=5188&id=5247

REVISION DETAIL
  https://phab.mercurial-scm.org/D2030

AFFECTED FILES
  mercurial/sshpeer.py

CHANGE DETAILS

diff --git a/mercurial/sshpeer.py b/mercurial/sshpeer.py
--- a/mercurial/sshpeer.py
+++ b/mercurial/sshpeer.py
@@ -173,8 +173,7 @@
     # End of _basewirecommands interface.
 
     def _validaterepo(self, sshcmd, args, remotecmd, sshenv=None):
-        # cleanup up previous run
-        self._cleanup()
+        assert self._pipei is None
 
         cmd = '%s %s %s' % (sshcmd, args,
             util.shellquote("%s -R %s serve --stdio" %



To: indygreg, #hg-reviewers, lothiraldan, yuja
Cc: mercurial-devel


More information about the Mercurial-devel mailing list