D2061: sshpeer: initial definition and implementation of new SSH protocol

[durin42 (Augie Fackler)]

durin42 added inline comments.

INLINE COMMENTS

> joerg.sonnenberger wrote in test-ssh-proto.t:396
> I'm a bit concerned about the order here. I would prefer to stay with the spirit of the original SSH protocol and go with the following order instead:
> 
> - client sends hello to the server
> - server sends its capabilities, including the supported "modern" protocol versions
> - client upgrades to the "best" version it supports and sends any additional wire capabilities it has
> 
> I don't think this changes the number of round-trips, but it slightly affects the number of commands that are "unversioned".

I don't feel super-strongly. I think my bias is to let the upgrade happen prior to the hello so that we can have custom servers in the future not have to support the bad old framing. I'll land the patch as is, but we can continue discussing it a bit here or on the list if I haven't convinced you. :)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2061

To: indygreg, #hg-reviewers
Cc: durin42, joerg.sonnenberger, mercurial-devel