D2086: wireproto: remove unused proto argument from supportedcompengines
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Thu Feb 8 00:27:22 UTC 2018
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
In theory, the protocol should be passed to this function. But the
argument isn't being used and it is getting in the way of refactoring.
So let's remove it. We can always add it back later if we need it
again.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2086
AFFECTED FILES
mercurial/wireproto.py
mercurial/wireprotoserver.py
CHANGE DETAILS
diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py
+++ b/mercurial/wireprotoserver.py
@@ -192,7 +192,7 @@
break
# Now find an agreed upon compression format.
- for engine in wireproto.supportedcompengines(self._ui, self,
+ for engine in wireproto.supportedcompengines(self._ui,
util.SERVERROLE):
if engine.wireprotosupport().name in compformats:
opts = {}
diff --git a/mercurial/wireproto.py b/mercurial/wireproto.py
--- a/mercurial/wireproto.py
+++ b/mercurial/wireproto.py
@@ -587,7 +587,7 @@
return ui.configbool('server', 'bundle1')
-def supportedcompengines(ui, proto, role):
+def supportedcompengines(ui, role):
"""Obtain the list of supported compression engines for a request."""
assert role in (util.CLIENTROLE, util.SERVERROLE)
@@ -824,7 +824,7 @@
# FUTURE advertise minrx and mintx after consulting config option
caps.append('httpmediatype=0.1rx,0.1tx,0.2tx')
- compengines = supportedcompengines(repo.ui, proto, util.SERVERROLE)
+ compengines = supportedcompengines(repo.ui, util.SERVERROLE)
if compengines:
comptypes = ','.join(urlreq.quote(e.wireprotosupport().name)
for e in compengines)
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list