D2123: py3: replace file() with open() in test-import.t
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Sun Feb 11 12:41:19 UTC 2018
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2123
AFFECTED FILES
tests/test-import.t
CHANGE DETAILS
diff --git a/tests/test-import.t b/tests/test-import.t
--- a/tests/test-import.t
+++ b/tests/test-import.t
@@ -56,7 +56,7 @@
$ cat > dummypatch.py <<EOF
> from __future__ import print_function
> print('patching file a')
- > file('a', 'wb').write('line2\n')
+ > open('a', 'wb').write(b'line2\n')
> EOF
$ hg clone -r0 a b
adding changesets
@@ -291,7 +291,7 @@
> msg.set_payload('email commit message\n' + patch)
> msg['Subject'] = 'email patch'
> msg['From'] = 'email patcher'
- > file(sys.argv[2], 'wb').write(msg.as_string())
+ > open(sys.argv[2], 'wb').write(msg.as_string())
> EOF
@@ -389,7 +389,7 @@
> msg.set_payload('email patch\n\nnext line\n---\n' + patch)
> msg['Subject'] = '[PATCH] email patch'
> msg['From'] = 'email patcher'
- > file(sys.argv[2], 'wb').write(msg.as_string())
+ > open(sys.argv[2], 'wb').write(msg.as_string())
> EOF
@@ -829,7 +829,7 @@
$ hg init binaryremoval
$ cd binaryremoval
$ echo a > a
- $ $PYTHON -c "file('b', 'wb').write('a\x00b')"
+ $ $PYTHON -c "open('b', 'wb').write(b'a\x00b')"
$ hg ci -Am addall
adding a
adding b
To: pulkit, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list