D2165: githelp: cast commands to bytes

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Feb 12 02:40:31 EST 2018


pulkit added inline comments.

INLINE COMMENTS

> githelp.py:126
>  
> +    __str__ = __bytes__
> +

This should be `__str__ = encoding.strmethod(__bytes__)` otherwise we will get an error like __str__ returned a non-string value.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2165

To: indygreg, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list