D2133: py3: replace file() with open() in test-convert-git.t
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Mon Feb 12 03:46:23 EST 2018
pulkit added inline comments.
> yuja wrote in test-convert-git.t:423
> We'll need b"' and make `chr()` return bytes.
To make chr() return bytes, I did chr().encode('latin-1') but there is `UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in range(128) `error while writing to file. Python 2 also don't have the encoding argument to open which Python 3 has. Looks like need to write a .py file and execute that.
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel