[PATCH 4 of 4] log: add TODO comments about --line-range processing

Yuya Nishihara yuya at tcha.org
Mon Feb 12 07:28:16 EST 2018


On Mon, 12 Feb 2018 12:04:21 +0100, Denis Laxalde wrote:
> Yuya Nishihara a écrit :
> > This is totally unrelated topic, but how would we do if we want to support
> > non-contiguous range?
> > 
> >   -L file,a:b,c:d
> > 
> > is ambiguous because file may contain ",".
> 
> I guess we could iteratively rsplit(",", 1) the file pattern and try to
> parse "from:to" until it fails, meaning that the remaining would be the
> file name. Slightly more complicated than it is now, but still doable I
> think.

That doesn't sound nice because only reason we've introduced -L was to reliably
split linerange from file pattern. "1:2" looks odd, but is a valid filename on
non-Windows.


More information about the Mercurial-devel mailing list