D2216: httppeer: remove httpspeer
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Feb 13 03:48:45 UTC 2018
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
All it did was verify at construction time that Mercurial supports
TLS. instance() is what's used to construct peer instances. So
we can just inline this check into that function and do away with
the type variant.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2216
AFFECTED FILES
mercurial/httppeer.py
CHANGE DETAILS
diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py
--- a/mercurial/httppeer.py
+++ b/mercurial/httppeer.py
@@ -480,22 +480,15 @@
def _abort(self, exception):
raise exception
-class httpspeer(httppeer):
- def __init__(self, ui, path):
- if not url.has_https:
- raise error.Abort(_('Python support for SSL and HTTPS '
- 'is not installed'))
- httppeer.__init__(self, ui, path)
-
def instance(ui, path, create):
if create:
raise error.Abort(_('cannot create new http repository'))
try:
- if path.startswith('https:'):
- inst = httpspeer(ui, path)
- else:
- inst = httppeer(ui, path)
+ if path.startswith('https:') and not url.has_https:
+ raise error.Abort(_('Python support for SSL and HTTPS '
+ 'is not installed'))
+ inst = httppeer(ui, path)
inst._fetchcaps()
return inst
To: indygreg, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list