D2229: narrowrepo: filter() is a generator on py3, wrap in list()

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Feb 13 12:14:54 EST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0c104ee51918: narrowrepo: filter() is a generator on py3, wrap in list() (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D2229?vs=5635&id=5642

REVISION DETAIL
  https://phab.mercurial-scm.org/D2229

AFFECTED FILES
  hgext/narrow/narrowrepo.py

CHANGE DETAILS

diff --git a/hgext/narrow/narrowrepo.py b/hgext/narrow/narrowrepo.py
--- a/hgext/narrow/narrowrepo.py
+++ b/hgext/narrow/narrowrepo.py
@@ -103,13 +103,13 @@
         def status(self, *args, **kwargs):
             s = super(narrowrepository, self).status(*args, **kwargs)
             narrowmatch = self.narrowmatch()
-            modified = filter(narrowmatch, s.modified)
-            added = filter(narrowmatch, s.added)
-            removed = filter(narrowmatch, s.removed)
-            deleted = filter(narrowmatch, s.deleted)
-            unknown = filter(narrowmatch, s.unknown)
-            ignored = filter(narrowmatch, s.ignored)
-            clean = filter(narrowmatch, s.clean)
+            modified = list(filter(narrowmatch, s.modified))
+            added = list(filter(narrowmatch, s.added))
+            removed = list(filter(narrowmatch, s.removed))
+            deleted = list(filter(narrowmatch, s.deleted))
+            unknown = list(filter(narrowmatch, s.unknown))
+            ignored = list(filter(narrowmatch, s.ignored))
+            clean = list(filter(narrowmatch, s.clean))
             return scmutil.status(modified, added, removed, deleted, unknown,
                                   ignored, clean)
 



To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list