D2067: changegroup: do not delta lfs revisions

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Feb 13 13:35:09 EST 2018


durin42 added a comment.


  In https://phab.mercurial-scm.org/D2067#34758, @indygreg wrote:
  
  > This looks mostly good. I would like a change to address a future footgun though.
  >
  > I would also appreciate someone familiar with censor and narrow to weigh in on the implications of disabling delta generation for revisions that have the censor and ellipsis flags set. I'm pretty sure narrow will cope since it reimplements changegroup generation. Not sure how censor will react. (But I know we already have random code for detecting censored nodes during changegroup generation.)
  
  
  Hmm, I could swear we already don't generate deltas for ellipsis nodes, and I'm having trouble defending the idea that maybe we should. Censor I'm 99% sure disables deltas. I'll ask adgar, but if you don't hear from me assume I was right.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2067

To: quark, indygreg, #hg-reviewers
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list