D2244: histedit: binascii.unhexlify (aka node.bin) throws new exception type on py3

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Feb 13 23:59:49 EST 2018


indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.


  I'm not super thrilled about this. Presumably we'll have this class of failure throughout the code base. What do you think about having `node.bin()` catch `binascii.Error` and re-raise as `TypeError`?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2244

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list