D2231: narrow: fix for getting the username when running http server
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Wed Feb 14 01:03:55 EST 2018
indygreg added inline comments.
INLINE COMMENTS
> narrowbundle2.py:331
> + ui = repo.ui
> + username = ui.shortuser(ui.environ.get('REMOTE_USER') or ui.username())
> + user_includes = ui.configlist(
`REMOTE_USER` is an HTTP-ism and I think it is a layering violation to look for `REMOTE_USER` in code that is supposed to be protocol agnostic.
What I'm trying to say is I think we'll need to tweak this ACL code further when it is moved to core.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2231
To: idlsoft, #hg-reviewers, durin42
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list