D2244: histedit: binascii.unhexlify (aka node.bin) throws new exception type on py3

[martinvonz (Martin von Zweigbergk)]

martinvonz added a comment.


  In https://phab.mercurial-scm.org/D2244#37169, @durin42 wrote:
  
  > I could go either way. A casual grep for "except TypeError" suggests we're looking at 4 or 5 locations *total*, so my bias is to do it at the callsites and avoid the annoyingly-large overhead of a wrapper function for something that's so fundamental.
  
  
  
  
  In https://phab.mercurial-scm.org/D2244#37233, @indygreg wrote:
  
  > In https://phab.mercurial-scm.org/D2244#37169, @durin42 wrote:
  >
  > > I could go either way. A casual grep for "except TypeError" suggests we're looking at 4 or 5 locations *total*, so my bias is to do it at the callsites and avoid the annoyingly-large overhead of a wrapper function for something that's so fundamental.
  >
  >
  > If it's only 4 or 5 call sites, then I'm not worried. I assumed it would be more widespread than that.
  
  
  I found a few more (at https://phab.mercurial-scm.org/rHGeefabd9ed3e1c8ed8ea023a0a76a76335185e2b3):
  
  lfcommands.py:332
  histedit.py:428
  shelve.py:194
  bookmarks.py:80
  context.py:528
  debugcommands.py:1541
  revlog.py:1360
  revlog.py:1407
  revset.py:1326
  tags.py:295

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2244

To: durin42, #hg-reviewers, indygreg
Cc: martinvonz, indygreg, mercurial-devel