D2244: histedit: binascii.unhexlify (aka node.bin) throws new exception type on py3

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Wed Feb 14 01:10:46 EST 2018


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D2244#37261, @indygreg wrote:
  
  > Now I'm second guessing accepting/committing this...
  
  
  Some thoughts:
  
  - This is probably not very well tested code (because it's an error path)
  - As long as we grep for TypeError and add binascii.Error in all those places, we're probably fine
  - Extensions need to be fixed too
  
  I think I'd prefer to define our own node.bin() with the old contract (IOW to wrap it)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2244

To: durin42, #hg-reviewers, indygreg
Cc: martinvonz, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list