D2253: releasenotes: mention changeset with warning and abort

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Feb 14 04:58:00 EST 2018


pulkit added a comment.


  I think ordering on the patches here is wrong. https://phab.mercurial-scm.org/D2255 seems to be parent of this one. Also can you add related tests?

INLINE COMMENTS

> releasenotes.py:315
> +                raise error.Abort(_('changeset %s: release notes directive %s '
> +                        'lacks content') % (node.hex(ctx.node()), directive))
>  

No need for `node.hex(ctx.node())`, just use ctx.

> releasenotes.py:329
> +                    repo.ui.warn(_('changeset %s: unexpected block in release '
> +                    'notes directive %s\n') % (node.hex(ctx.node()), directive))
>  

Same as above.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2253

To: rishabhmadan96, #hg-reviewers
Cc: pulkit, mercurial-devel


More information about the Mercurial-devel mailing list