D2231: narrow: fix for getting the username when running http server

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Feb 15 17:47:11 EST 2018


martinvonz added inline comments.

INLINE COMMENTS

> indygreg wrote in narrowbundle2.py:331
> `REMOTE_USER` is an HTTP-ism and I think it is a layering violation to look for `REMOTE_USER` in code that is supposed to be protocol agnostic.
> 
> What I'm trying to say is I think we'll need to tweak this ACL code further when it is moved to core.

But you're okay with this version for now? This commit is currently the bottom-most draft commit in the "committed" repo, so please accept it if you're okay with it. I would have accepted, but I saw this comment and wasn't sure if you thought this was bad enough to not queue it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D2231

To: idlsoft, #hg-reviewers, durin42
Cc: martinvonz, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list