D2333: py3: make sure we open the files in bytes mode
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Sun Feb 18 09:12:32 EST 2018
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> posix.py:116
> # switch file to link
> fp = open(f)
> data = fp.read()
Two more missing 'b's, here
> posix.py:124
> # failed to make a link, rewrite file
> fp = open(f, "w")
> fp.write(data)
and here.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2333
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list