D2317: manifest: use list(dict) instead of dict.keys() to get a list of keys
durin42 (Augie Fackler)
phabricator at mercurial-scm.org
Sun Feb 18 12:35:09 EST 2018
durin42 added a comment.
In https://phab.mercurial-scm.org/D2317#38442, @indygreg wrote:
> This one feels sub-optimal because of the amount of intermediary variables. But I think it should be OK.
Agreed, though it's equivalent to what's already happening with .keys().
So far treemanifest code hasn't been prominent in profiles at Google, so it's not high on my optimization list.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2317
To: durin42, #hg-reviewers, pulkit, indygreg
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list